Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] prevent double decoding of params #7521

Merged
merged 1 commit into from
Nov 7, 2022
Merged

[fix] prevent double decoding of params #7521

merged 1 commit into from
Nov 7, 2022

Conversation

dmkret
Copy link

@dmkret dmkret commented Nov 6, 2022

Closes #7515

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2022

🦋 Changeset detected

Latest commit: 53a01a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

Could you add a test that fails with the old way but succeeds with the fix?

@Rich-Harris
Copy link
Member

thank you!

@benmccann
Copy link
Member

Sorry I didn't get a chance to review this before it got merged, but it looks like this has a bug in it: #7554. Any chance you'd be able to take a look at it @dmkret ?

@dmkret
Copy link
Author

dmkret commented Nov 9, 2022

@benmccann I'll take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

decode_params doesn't handle decoded % symbol
4 participants