-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respond with status code 413 if request body is too large #6936
Conversation
🦋 Changeset detectedLatest commit: 400be4c The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
req.destroy( | ||
new Error( | ||
cancelled = true; | ||
controller.error( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not well-versed with the details of this code section - could you explain briefly why this change is necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This returns an error in the RequestHandler
and from there the status code gets into the Response, otherwise the connection is simply terminated without a response. cancelled = true
is needed so that controller.close()
does not occur in the req.on('end', () => ...)
because calling close()
on a closed controller
causes an unhandled exception.
Fixes #6920
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0