Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] allow Vite plugins to output mutable assets #5416

Merged
merged 11 commits into from
Jul 8, 2022
Merged

Conversation

benmccann
Copy link
Member

@userquin is trying to get vite-plugin-pwa working with SvelteKit. That plugin adds a mutable manifest to the bundle. Since the bundle is written to the outDir we need the outDir to be set to client instead of client/immutable

@benmccann benmccann added the bug Something isn't working label Jul 8, 2022
@changeset-bot
Copy link

changeset-bot bot commented Jul 8, 2022

🦋 Changeset detected

Latest commit: 26caa80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member Author

Looks like adapter-static is ending up with immutable in the path twice somehow:

cd packages/adapter-static/test/apps/spa
pnpm start
404 - /_app/immutable/immutable/start-d357e0b9.js

packages/kit/src/vite/index.js Outdated Show resolved Hide resolved
packages/kit/src/vite/index.js Outdated Show resolved Hide resolved
@benmccann
Copy link
Member Author

this looks good to me. thanks for the help getting it working, Rich!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants