-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow %-encoding in route filenames #5056
Conversation
🦋 Changeset detectedLatest commit: 3b295b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Is this a breaking change? Is this related to requiring all special characters in routes to be URL-encoded in the path names - or is that work separate? (Did it already happen and I missed it?) |
That's separate — this is basically just fixing a bug in how Vite names chunks if percent-encoded characters are involved |
I don't think it's a breaking change |
I think this should work, but we should document it This would be a breaking change for anyone who has |
Closes #5029. I'm at my least confident when dealing with anything encoding-related, so would appreciate a sanity check on this one
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0