-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: defer when clicking hash links with data-sveltekit-reload #12866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fd0a3aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eltigerchino
changed the title
fix: defer to browser when clicking hash links
fix: defer when clicking hash links with data-sveltekit-reload
Oct 23, 2024
eltigerchino
changed the title
fix: defer when clicking hash links with data-sveltekit-reload
fix: do not reload when clicking hash links with data-sveltekit-reload
Oct 23, 2024
eltigerchino
changed the title
fix: do not reload when clicking hash links with data-sveltekit-reload
fix: defer when clicking hash links with data-sveltekit-reload
Oct 23, 2024
eltigerchino
commented
Oct 23, 2024
dummdidumm
reviewed
Oct 23, 2024
Co-authored-by: Simon H <[email protected]>
dummdidumm
approved these changes
Oct 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12582
fixes #12188
Replaces #10032 by usinglocation.replace
to allow the browser to handle hash link behaviour instead #10856 (comment)This PR ensures that clicking on a hash link with the reload option avoids the usual behaviour of thinking the page will reload and instead allows it to be handled as if the option wasn't enabled (hash links on the same page never reload the page).
It also fixes a behaviour where an element doesn't get focused when clicking on the hash link more than once.
TODO:
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits