Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use node: imports in adapter-node to support Deno #12785

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

Conduitry
Copy link
Member

This adjusts the bundling of the Node adapter so that imports from bundled dependencies (sirv, totalist) are converted into their node: versions, without needing code changes in those libraries. Fixes #12783.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Oct 9, 2024

🦋 Changeset detected

Latest commit: 0bdaba2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to fix in sirv and totalist, but this is a bit cleaner than the last attempt (#12698), so might as well unblock things

@benmccann benmccann merged commit 64deae5 into sveltejs:main Oct 10, 2024
12 checks passed
@github-actions github-actions bot mentioned this pull request Oct 10, 2024
@Conduitry Conduitry deleted the gh-12783 branch October 10, 2024 01:08
@eltigerchino
Copy link
Member

Thanks for this! I must've mucked up something when I tried it. Sorry for falsely reporting that this didn't work initially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to run SvelteKit apps using Deno 2 due to handler.js imports
3 participants