Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add node custom inspect for URL.searchParams #12763

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Oct 7, 2024

fixes #11482

Since URL.searchParams is an object too, we needed to make the tracked property loggable, similar to the URL object itself. This prevents the crashing when logging it in the server load.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@eltigerchino eltigerchino added the bug Something isn't working label Oct 7, 2024
Copy link

changeset-bot bot commented Oct 7, 2024

🦋 Changeset detected

Latest commit: 91d78cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eltigerchino eltigerchino changed the title fix: add node custom inspect for tracked search params object fix: add node custom inspect for URL.searchParams Oct 7, 2024
@dummdidumm dummdidumm merged commit 2292170 into main Oct 7, 2024
13 checks passed
@dummdidumm dummdidumm deleted the fix-logging-server-search-params branch October 7, 2024 10:59
@github-actions github-actions bot mentioned this pull request Oct 7, 2024
@eltigerchino eltigerchino mentioned this pull request Oct 9, 2024
6 tasks
dummdidumm pushed a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging url.searchParams in server load function crashes
2 participants