-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add node:
prefix and import instead of using globals
#12641
Conversation
🦋 Changeset detectedLatest commit: 0e37d0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
We've got an eslint rule to enforce I wonder if there's also one to ensure globals like that are imported. It could be worth requesting with eslint-plugin-n if it doesn't already exist |
Here it is: https://github.com/eslint-community/eslint-plugin-n/blob/HEAD/docs/rules/prefer-global/process.md We could turn it on in the common eslint config |
Ben has opened a PR with the node prefix changes for Polka lukeed/polka#212 |
I think we could merge this without the polka piece. Assuming the polka part is in a patch release then users can get it without any need for us to bump the version here. It'd be nice to do the eslint part though |
Not sure if I made the right changes here in regards to the extent of the new eslint rule. Do we only want it for |
see denoland/deno#17248 (comment)
Specifically imports
node:process
instead of relying on theprocess
global.TODO:
node:
prefix to polka importsPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits