-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: throw error if routes are configured in _routes.json #12360
Conversation
🦋 Changeset detectedLatest commit: 2e99678 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will adapter-cloudflare-workers
need the same change?
don't worry about the test failure. the tests are flaky
yes, we'll need a changeset
The I will generate the changelogs asap than :) |
Thank you! |
Close #12321
I don't know if it was the best choice, but I opted for throw error only if
_routes.json
exists and there are no configured routes in svelte.config.Let me know if you think Changelogs should be generated.
I don't think it's related, but
pnpm test
fails onPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits