breaking: apply @polka/compression middleware
#11952
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 61312bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
4 tasks
|
I don't think this is a good idea to apply unconditionally, and probably not even by default. There are more efficient solutions to use than Node for compressing your responses on the fly - and ones that won't directly compete with your app for CPU time on Node's single thread. Unless you're serving unencrypted HTTP to users, you're going to have some sort of reverse proxy sitting in front of your application anyway. |
|
Great points! I'll close this and send a docs PR instead |
|
I've sent the docs PR in #11957 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9593
We used to apply the
compressionmiddleware. However, that middleware is incompatible with streaming and has blocked users from filing issues or sending PRs to the repo. The newly available@polka/compressionmiddleware addresses those concernsThis could be merged together with #11945 and #11653 as part of a new major release for
adapter-node