-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support specifying the tsconfig in svelte-package #11698
feat: support specifying the tsconfig in svelte-package #11698
Conversation
🦋 Changeset detectedLatest commit: dec5793 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I don't understand why this is necessary or why it would apply only to svelte package |
Hi @benmccann, thanks for checking this PR ! In the context of a monorepo where two svelte libraries coexist, (example of a headless widget library and a styled widget library depending on the headless), I would like to be able to have aliases in the default tsconfig.json, to navigate easier in the code in my IDE. I have set up a project to showcase the behavior here. Being able to able to run svelte-package with an option tsconfig would allow to separate the tsconfig for IDE code navigation from the What do you think ? |
hi @benmccann @dummdidumm, a little reminder on this |
sorry to chase again, is there anything I need to update / clarify for this ? |
Sorry for being silent for so long - I'm currently focused on Svelte 5. I'll look into this soon, I promise! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
closes #9373
Adds the option
tsconfig
to svelte-package, allowing to specify which tsconfig / jsconfig to use during the packaging.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits