-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix obscure characters in docs #11679
Conversation
|
Hm. These should work, and I'm pretty sure it used to. I think I'd prefer to figure out what's going wrong with character encoding than to hide it by changing the character we're using. |
Hm, this stackoverflow article could be relevant? |
I bet this is somehow related to #11649 — we switched from using |
What's even weirder is that when the page is rendered locally via |
Using |
Seems like an encoding issue on file read? I've found out that the em dash (—) char is represented as three characters (â��), whose unicode codes correspond to the byte representation of the em dash, if it helps. I tried investigating the solution further but I still don't understand why it doesn't happen everytime (https://kit.svelte.dev/docs/routing is fine) Update: Update 2: assetsInlineLimit: (file) => {
return !file.endsWith('.md');
} to vite's config.build works. |
It's a bug in |
closing in favour of #11682 — thank you! |
For whatever reason, the dashes render as obscure characters:
This pr aims to fix that :) (although I'm not sure how many more places this issue appears in)
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits