Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node compat #11675

Merged
merged 5 commits into from
Jan 19, 2024
Merged

Node compat #11675

merged 5 commits into from
Jan 19, 2024

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Jan 19, 2024

Following #10544 — we can do the same thing for Vercel and Netlify. Have just done Vercel so far


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jan 19, 2024

🦋 Changeset detected

Latest commit: 81fd091

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sveltejs/adapter-vercel Minor
@sveltejs/adapter-netlify Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

I'm not sure that adapter-vercel still needs the external option after this. Should we deprecate it and see if anyone's using it for something else? Or even drop it and make this a major release of the adapter?

@Conduitry
Copy link
Member

@benmccann There was a brief conversation about that on Discord - https://discord.com/channels/457912077277855764/571775594002513921/1197729911771775057

@Rich-Harris Rich-Harris merged commit df381db into main Jan 19, 2024
13 checks passed
@Rich-Harris Rich-Harris deleted the node-compat branch January 19, 2024 16:25
@github-actions github-actions bot mentioned this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants