Memory leak? #9427

kevinrenskers · 2023-03-15T16:13:08Z

Describe the bug

I am seeing the memory usage of my SvelteKit app, running with the Node adapter, going up and up. I'm not sure how the server's memory usage can keep increasing, all the svelte stores for example are only used in the browser, and other than that the server requests should be stateless, right?

See https://discord.com/channels/457912077277855764/1081891569390583898 for a discussion about this.

Reproduction

As far as I know, any project will show this problem.

Create a new skeleton project. No need to add TypeScript, Prettier, ESLint or anything else.

npm create svelte@latest repro
cd repro
npm i
npm run build
npm run preview

Open http://127.0.0.1:4173/, open the activity monitor (on macOS) or top or whatever else to see memory usage of the Node process, and refresh the webpage a whole bunch of times. You'll see the memory go up. It's slow to increase with such a simple skeleton project so you might need to refresh a whole bunch of times, but it does go up.

In my moderately popular website it goes up by about 300 MB per day.

Logs

No response

System Info

System:
    OS: macOS 13.2.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 274.47 MB / 32.00 GB
    Shell: 3.6.0 - /opt/homebrew/bin/fish
  Binaries:
    Node: 16.17.0 - ~/Library/pnpm/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 8.15.0 - ~/Library/pnpm/npm
  Browsers:
    Chrome: 111.0.5563.64
    Edge: 110.0.1587.69
    Firefox: 110.0.1
    Safari: 16.3
  npmPackages:
    @sveltejs/adapter-auto: ^2.0.0 => 2.0.0
    @sveltejs/kit: ^1.5.0 => 1.11.0
    svelte: ^3.54.0 => 3.56.0
    vite: ^4.0.0 => 4.1.4

Severity

serious, but I can work around it

Additional Information

I have to restart my Node server once in a while or the server just runs out of memory.

The text was updated successfully, but these errors were encountered:

vhscom · 2023-03-24T17:54:22Z

@kevinrenskers this issue appears to be related to Undici, which is used under the hood for the fetch implementation in Node. As a workaround, you may be able to swap out SvelteKit fetch with Axios until this bug is resolved.

kevinrenskers · 2023-03-24T18:34:56Z

Is that being tracked in their repo somewhere?

Switching to Axios is not really an option, I don't have time to go through the entire app to make such a refactor.

eltigerchino · 2023-04-11T14:27:35Z

This should be closed by #9591 where we pin undici's version.
@kevinrenskers can you confirm if this issue is still present for you after upgrading to @sveltejs/[email protected] ?

kevinrenskers · 2023-04-11T14:46:31Z

I've deployed a new version, will keep an eye on the memory usage and report back.

This was the last 30 days, for reference:

kevinrenskers · 2023-04-11T16:47:47Z

I don't think that helped, it keeps increasing in basically the same speed as before; 30 MB in 2 hours. Which doesn't sound like a huge amount, but is 360 MB per day.

Update:

It just keeps on rising, no change.

Is nobody else seeing this? Or is nobody else tracking their server stats?

Update 2:

🤷‍♂️

machycek · 2023-04-14T04:45:39Z

@kevinrenskers we are having the same issue actually

gtm-nayan · 2023-04-14T07:44:34Z

@kevinrenskers
Was this using the default server that's provided by the adapter or using just the handler in a custom server?

kevinrenskers · 2023-04-14T07:45:25Z

The default server, using adapter-node.

gtm-nayan · 2023-04-14T07:46:07Z

And this also happens with npm run preview?

kevinrenskers · 2023-04-14T07:58:26Z

I don't know, I don't want to run my production website that way to find out 😅 I'll try it locally, see what happens.

dominikg · 2023-04-14T12:14:15Z

can you please confirm the exact versions of operating system, node, @sveltejs/kit, @sveltejs/adapter-node and undici where you are observing this behavior?

kevinrenskers · 2023-04-15T09:43:11Z

can you please confirm the exact versions of operating system, node, @sveltejs/kit, @sveltejs/adapter-node and undici where you are observing this behavior?

  System:
    OS: Linux 5.10 Debian GNU/Linux 11 (bullseye) 11 (bullseye)
    CPU: (4) x64 AMD EPYC Processor
    Memory: 4.68 GB / 7.58 GB
    Container: Yes
    Shell: 5.1.4 - /bin/bash
  Binaries:
    Node: 16.19.1 - /usr/bin/node
    npm: 8.19.3 - /usr/bin/npm
  npmPackages:
    @sveltejs/adapter-node: ^1.0.0 => 1.2.3
    @sveltejs/kit: ^1.0.0 => 1.15.4
    svelte: ^3.54.0 => 3.58.0

undici: 5.20.0

kevinrenskers · 2023-04-15T09:46:22Z

And this also happens with npm run preview?

Yes

stalkerg · 2023-04-19T14:27:39Z

Can you try "@sveltejs/adapter-node": "1.2.2", and "undici": "5.20.0" and also do this:

"overrides": {
		"@sveltejs/kit": {
			"undici": "$undici"
		},
		"@sveltejs/adapter-node": {
			"undici": "$undici"
		}
	}

I have no issue now. Also, undici devs fixed such a memory leak (very tricky way actually!).

kevinrenskers · 2023-04-19T14:37:16Z

I'm already using undici 5.20.0 though, but sure I'll try. Where do I put these overrides?

stalkerg · 2023-04-19T14:57:43Z

on the same level as "devDependencies": { also, very important to downgrade adapter-node as well (undici bundling by bable)

kevinrenskers · 2023-04-19T15:29:24Z

So far it seems improved, but I'll know for sure in a day or so. I'll report back.

Update: after 4 hours memory usage has increased by about 15 MB. Let's see what's it like in 24 hours.

kevinrenskers · 2023-04-20T08:16:14Z

I think the leak is indeed solved 🎉
At first the memory increased by about 15 MB, but it's been stable at ~60 MB for about 12 hours now. Huge difference.

dummdidumm · 2023-04-20T09:28:48Z

@stalkerg am I seing this correctly that undici has released the fix for the memory leak in https://github.com/nodejs/undici/releases/tag/v5.21.1 so we can bump to latest undici again?

stalkerg · 2023-04-21T01:02:04Z

@dummdidumm yes! Now it's fixed without a timeout breakage. My small local tests are working well.

kevinrenskers · 2023-04-24T17:06:02Z

This fix isn't released yet, right? Because I updated all my dependencies, removed the overrides, and the problem is back in full force.

You can clearly see when I deployed the changes 😅

eltigerchino · 2023-04-24T17:07:06Z

This fix isn't released yet, right? Because I updated all my dependencies, removed the overrides, and the problem is back in full force.

No, it has not released yet.

kevinrenskers · 2023-04-24T17:17:36Z

Is there an ETA on a release? So I can decide if I should revert my change or just wait a bit.

eltigerchino · 2023-04-25T01:38:03Z

Is there an ETA on a release? So I can decide if I should revert my change or just wait a bit.

It's out now! :) https://github.com/sveltejs/kit/releases/tag/%40sveltejs%2Fkit%401.15.8

stalkerg · 2023-04-25T01:56:22Z

@s3812497 it's not enough; we also must update the node adapter because of bundling (this issue is not in direct dependencies)

eltigerchino · 2023-04-25T01:57:59Z

@s3812497 it's not enough; we also must update the node adapter because of bundling (this issue is not in direct dependencies)

Ah, sorry about that. I didn't know.

stalkerg · 2023-04-25T01:59:22Z

@s3812497 @sveltejs/adapter-node/files/shims.js still includes old undici and the node adapter will use it.

stalkerg · 2023-04-25T02:00:44Z

@dummdidumm we must update adapter-node as well, just sveltekit is not enough.

itssumitrai · 2023-04-26T14:46:26Z

Can we fix this asap ? Our production server capacity is lost by more than 100%. Basically we need to have more than twice the servers and the perf has become really bad as well. We have no choice other than to pin down adapter node. Can this issue get more traction ?

sveltejs/kit#8239 sveltejs/kit#9427 Hay que vigilar si se resuelve el problema de undici

henryson · 2024-11-29T07:59:30Z

About 1.5 years later I experience this same problem. I thought this thread would help me but since I run svelte-kit 2.5.4 I guess the above fix should already be there. Maybe a similar problem has arised again? Or should I continue look elsewhere?

stalkerg · 2024-11-29T08:14:45Z

@henryson did you use latest stable nodejs? Also, are you sure you have totally same issue? You can go to undici tracker than.

henryson · 2024-11-29T08:29:23Z

Hi, thanks for quick response. No I am not sure at all. But our app hangs after less than a day (in production) and I am trying to look for all ways to fix this. We were running node 21.7 but I downgraded to 20.18.1 because some other post said it could work. But it didn’t. Cheers, Josef Från: Yury Zhuravlev ***@***.***> Datum: fredag, 29 november 2024 09:15 Till: sveltejs/kit ***@***.***> Kopia: Josef Henryson ***@***.***>, Mention ***@***.***> Ämne: Re: [sveltejs/kit] Memory leak? (Issue #9427) @henryson<https://github.com/henryson> did you use latest stable nodejs? Also, are you sure you have totally same issue? You can go to undici tracker than. — Reply to this email directly, view it on GitHub<#9427 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACC72JZBEYUC2XT4OPPKSBT2DAPAXAVCNFSM6AAAAABSWRTB36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBXGI4TGMRQGI>. You are receiving this because you were mentioned.Message ID: ***@***.***>

stalkerg · 2024-11-29T10:08:27Z

You should isolate your issue and make small reproduction demo. Without it, any suggest will not too different from random advice.

dominikg · 2024-11-29T10:12:39Z

this specific issue has been resolved. it makes no sense to discuss all possible memory leaks in the comments here and notify participants in the process. - locking it now, please file a new one with a reproduction and downloadable heap snapshots for comparison that show it is actually sveltekit causing the memory leak.

If you are unsure how to do this, please join https://svelte.dev/chat and ask for help in #help-svelte-and-kit

Rich-Harris added the bug Something isn't working label Mar 17, 2023

Rich-Harris added this to the soon milestone Mar 17, 2023

gtm-nayan mentioned this issue Apr 21, 2023

chore: revert undici pin and upgrade #9740

Merged

5 tasks

dummdidumm closed this as completed in #9740 Apr 21, 2023

Conduitry reopened this Apr 25, 2023

Conduitry mentioned this issue Apr 25, 2023

chore: update dependencies #9761

Merged

benmccann closed this as completed in #9761 Apr 27, 2023

javiersanp added a commit to OSM-es/visor-catastro that referenced this issue May 15, 2023

Parchea memory leak de node en producción

f952aca

sveltejs/kit#8239 sveltejs/kit#9427 Hay que vigilar si se resuelve el problema de undici

sveltejs locked as off-topic and limited conversation to collaborators Nov 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Memory leak? #9427

Memory leak? #9427

kevinrenskers commented Mar 15, 2023 •

edited

Loading

vhscom commented Mar 24, 2023

kevinrenskers commented Mar 24, 2023 •

edited

Loading

eltigerchino commented Apr 11, 2023 •

edited

Loading

kevinrenskers commented Apr 11, 2023 •

edited

Loading

kevinrenskers commented Apr 11, 2023 •

edited

Loading

machycek commented Apr 14, 2023

gtm-nayan commented Apr 14, 2023

kevinrenskers commented Apr 14, 2023

gtm-nayan commented Apr 14, 2023

kevinrenskers commented Apr 14, 2023

dominikg commented Apr 14, 2023

kevinrenskers commented Apr 15, 2023 •

edited

Loading

kevinrenskers commented Apr 15, 2023

stalkerg commented Apr 19, 2023

kevinrenskers commented Apr 19, 2023

stalkerg commented Apr 19, 2023

kevinrenskers commented Apr 19, 2023 •

edited

Loading

kevinrenskers commented Apr 20, 2023

dummdidumm commented Apr 20, 2023

stalkerg commented Apr 21, 2023

kevinrenskers commented Apr 24, 2023 •

edited

Loading

eltigerchino commented Apr 24, 2023 •

edited

Loading

kevinrenskers commented Apr 24, 2023

eltigerchino commented Apr 25, 2023

stalkerg commented Apr 25, 2023

eltigerchino commented Apr 25, 2023

stalkerg commented Apr 25, 2023

stalkerg commented Apr 25, 2023

itssumitrai commented Apr 26, 2023

henryson commented Nov 29, 2024

stalkerg commented Nov 29, 2024

henryson commented Nov 29, 2024 via email

stalkerg commented Nov 29, 2024

dominikg commented Nov 29, 2024

Memory leak? #9427

Memory leak? #9427

Comments

kevinrenskers commented Mar 15, 2023 • edited Loading

Describe the bug

Reproduction

Logs

System Info

Severity

Additional Information

vhscom commented Mar 24, 2023

kevinrenskers commented Mar 24, 2023 • edited Loading

eltigerchino commented Apr 11, 2023 • edited Loading

kevinrenskers commented Apr 11, 2023 • edited Loading

kevinrenskers commented Apr 11, 2023 • edited Loading

machycek commented Apr 14, 2023

gtm-nayan commented Apr 14, 2023

kevinrenskers commented Apr 14, 2023

gtm-nayan commented Apr 14, 2023

kevinrenskers commented Apr 14, 2023

dominikg commented Apr 14, 2023

kevinrenskers commented Apr 15, 2023 • edited Loading

kevinrenskers commented Apr 15, 2023

stalkerg commented Apr 19, 2023

kevinrenskers commented Apr 19, 2023

stalkerg commented Apr 19, 2023

kevinrenskers commented Apr 19, 2023 • edited Loading

kevinrenskers commented Apr 20, 2023

dummdidumm commented Apr 20, 2023

stalkerg commented Apr 21, 2023

kevinrenskers commented Apr 24, 2023 • edited Loading

eltigerchino commented Apr 24, 2023 • edited Loading

kevinrenskers commented Apr 24, 2023

eltigerchino commented Apr 25, 2023

stalkerg commented Apr 25, 2023

eltigerchino commented Apr 25, 2023

stalkerg commented Apr 25, 2023

stalkerg commented Apr 25, 2023

itssumitrai commented Apr 26, 2023

henryson commented Nov 29, 2024

stalkerg commented Nov 29, 2024

henryson commented Nov 29, 2024 via email

stalkerg commented Nov 29, 2024

dominikg commented Nov 29, 2024

kevinrenskers commented Mar 15, 2023 •

edited

Loading

kevinrenskers commented Mar 24, 2023 •

edited

Loading

eltigerchino commented Apr 11, 2023 •

edited

Loading

kevinrenskers commented Apr 11, 2023 •

edited

Loading

kevinrenskers commented Apr 11, 2023 •

edited

Loading

kevinrenskers commented Apr 15, 2023 •

edited

Loading

kevinrenskers commented Apr 19, 2023 •

edited

Loading

kevinrenskers commented Apr 24, 2023 •

edited

Loading

eltigerchino commented Apr 24, 2023 •

edited

Loading