Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: change the plugin to an ESM-only package #932

Merged
merged 10 commits into from
Dec 2, 2024
Merged

feat!: change the plugin to an ESM-only package #932

merged 10 commits into from
Dec 2, 2024

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Nov 28, 2024

This PR changes the plugin to an ESM-only package.
However, it is not yet a fully ESM-only package, as we have not yet made the parser ESM.

Close #808

Copy link

changeset-bot bot commented Nov 28, 2024

🦋 Changeset detected

Latest commit: 7bae80a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-svelte Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ota-meshi ota-meshi marked this pull request as ready for review November 28, 2024 15:11
@baseballyama
Copy link
Member

baseballyama commented Dec 2, 2024

So, after upgrade parser version to v1.0.0-next.2, it will be fully ESM-only package?

@ota-meshi
Copy link
Member Author

Yeah! If we upgrade the parser it becomes a complete ESM package. I'll do that at lunchtime.

@ota-meshi
Copy link
Member Author

I updated the parser and it seems to work fine 😄

Copy link
Member

@baseballyama baseballyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will use to test this version after release this PR.

@baseballyama baseballyama merged commit b136ab4 into main Dec 2, 2024
16 checks passed
@baseballyama baseballyama deleted the esm branch December 2, 2024 03:41
baseballyama pushed a commit that referenced this pull request Dec 2, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`main` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `main`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## [email protected]

### Major Changes

- [#932](#932)
[`b136ab4`](b136ab4)
Thanks [@ota-meshi](https://github.com/ota-meshi)! - feat!: change the
plugin to an ESM-only package

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESM-only plugin
2 participants