feat: add config option for foreign elements in svelte/html-self-closing rule
#841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 41a8af0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jrmajor
commented
Aug 10, 2024
| @@ -0,0 +1,140 @@ | |||
| export const voidElements = [ | |||
There was a problem hiding this comment.
Moved from removed void-elemets.ts file. It's actually different that the list that Svelte uses (https://github.com/sveltejs/svelte/blob/c32a91891fc647998f738371a012fcba97d56e50/packages/svelte/src/utils.js#L16-L33).
| 'wbr' | ||
| ]; | ||
|
|
||
| export const svgElements = [ |
There was a problem hiding this comment.
| 'vkern' | ||
| ]; | ||
|
|
||
| export const mathmlElements = [ |
There was a problem hiding this comment.
ota-meshi
approved these changes
Sep 13, 2024
ota-meshi
pushed a commit
that referenced
this pull request
Sep 13, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Minor Changes - [#841](#841) [`85053a1`](85053a1) Thanks [@jrmajor](https://github.com/jrmajor)! - feat: add config option for foreign elements in `svelte/html-self-closing` rule ### Patch Changes - [#853](#853) [`690c04e`](690c04e) Thanks [@ota-meshi](https://github.com/ota-meshi)! - fix: update svelte-eslint-parser to 0.41.1 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds separate configuration option for foreign (SVG and MathML) elements to
svelte/html-self-closingrule.According to HTML spec (https://html.spec.whatwg.org/multipage/syntax.html#elements-2):
This means that
<div/>is invalid, while<path/>(which is a SVG element) is OK. This configuration option would allow users to take advantage of the terser SVG syntax, while still using correct HTML syntax for normal elements (likediv).Closes #837.