Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use synckit to support postcss-load-config v5 #665

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JounQin
Copy link
Collaborator

@JounQin JounQin commented Jan 11, 2024

close #636

@JounQin JounQin added enhancement New feature or request internal This affects the hidden internals labels Jan 11, 2024
@JounQin JounQin requested a review from ota-meshi January 11, 2024 11:56
Copy link

changeset-bot bot commented Jan 11, 2024

⚠️ No Changeset found

Latest commit: fef7962

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JounQin JounQin force-pushed the feat/synckit branch 3 times, most recently from b23d36f to 69445ac Compare January 11, 2024 12:07
@JounQin
Copy link
Collaborator Author

JounQin commented Jan 11, 2024

  76:5  error  "postcss-load-config@^5.0.2" is not compatible with "node@^14.17.0||>=16.0.0". Allowed is: "node@>=18.0.0"  node-dependencies/compat-engines
  81:5  error  "synckit@^0.9.0" is not compatible with "node@^14.17.0||>=16.0.0". Allowed is: "node@^14.18.0||>=16.0.0"    node-dependencies/compat-engines

Do we want to release a major version for this?

@JounQin
Copy link
Collaborator Author

JounQin commented Jan 11, 2024

@JounQin JounQin mentioned this pull request Jan 11, 2024
@ota-meshi
Copy link
Member

Thank you for the PR.
I would like to release eslint-plugin-svelte v2.36 after the stable version of svelte v5 is released, and then work on the next major version.

@baseballyama
Copy link
Member

Even if Svelte 5 is released, I don't think we can drop Node < 18 as long as we continue to support Svelte 4 and Svelte 3.
I think it is a good idea to support only Svelte 5 in the next major version.

@JounQin
Copy link
Collaborator Author

JounQin commented Jan 21, 2024

I meant this PR should target on the next major version.

The main itself is targeting Svelte v5, how can I create a PR for old releases?

cc @ota-meshi

@ota-meshi
Copy link
Member

There is currently no way to manage multiple versions in this repository 😓

@JounQin
Copy link
Collaborator Author

JounQin commented Jan 21, 2024

It needs multiple branches. For example https://github.com/mdx-js/eslint-mdx/tree/release-v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal This affects the hidden internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to postcss-load-config 5.0
3 participants