Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify docs for svelte/no-target-blank #656

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Jan 3, 2024

The behavior of allowReferrer was very confusing to me because I thought it was referring to the rel attribute and I did not understand it's actually referring to the Referer header being allowed

I was also very confused about the security vulnerability being referred to. I assumed it was related to protecting the user's privacy by not passing the referrer header. When I happened to click the reference link I saw that I had been misunderstanding the purpose of this rule and what exactly it was doing.

Copy link

changeset-bot bot commented Jan 3, 2024

⚠️ No Changeset found

Latest commit: 3ce7eb4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann benmccann changed the title docs: clarify meaning of allowReferrer docs: clarify docs for svelte/no-target-blank Jan 3, 2024
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ota-meshi ota-meshi merged commit 26a3823 into sveltejs:main Jan 3, 2024
7 of 11 checks passed
@benmccann benmccann deleted the patch-2 branch January 3, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants