chore: do not run infinite-reactive-loop rule on Svelte 5 with runes (

#1006)
sveltejs · Jan 14, 2025 · 5fd91ba · 5fd91ba
1 parent 91999e3
commit 5fd91ba
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/.changeset/smart-brooms-relax.md b/.changeset/smart-brooms-relax.md
@@ -0,0 +1,5 @@
+---
+'eslint-plugin-svelte': patch
+---
+
+chore: do not run `infinite-reactive-loop` rule on Svelte 5 with runes
diff --git a/packages/eslint-plugin-svelte/src/rules/infinite-reactive-loop.ts b/packages/eslint-plugin-svelte/src/rules/infinite-reactive-loop.ts
@@ -378,7 +378,17 @@ export default createRule('infinite-reactive-loop', {
 			unexpectedCall:
 				'Possibly it may occur an infinite reactive loop because this function may update `{{variableName}}`.'
 		},
-		type: 'suggestion'
+		type: 'suggestion',
+		// Do not run this rule on Svelte 5 with runes.
+		conditions: [
+			{
+				svelteVersions: ['3/4']
+			},
+			{
+				svelteVersions: ['5'],
+				runes: [false, 'undetermined']
+			}
+		]
 	},
 	create(context) {
 		return {