Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES5 transpiling ? #6

Closed
thollander opened this issue May 25, 2019 · 3 comments
Closed

ES5 transpiling ? #6

thollander opened this issue May 25, 2019 · 3 comments

Comments

@thollander
Copy link

Thank you for the template @Rich-Harris !

I see that there is no Babel/Buble plugged to this template.

Do you think it should be done (for consumers who will use index.[m]js) ? Or should they implement it in their consumer stack ?

If you think it should be done in this repo, how would you define the supported browsers ?

@TheBosZ
Copy link

TheBosZ commented Jun 18, 2019

The official line is that support for ES5 is going to come from the project, not the component. Here's where the discussion is.

@Conduitry
Copy link
Member

If people are consuming a component written with this project in a Svelte app, they'll be consuming the original .svelte source files, and compiling them within their app, and so they'll be responsible for setting up whatever transpiling they need.

Transpiling within this project would only matter if someone were directly consuming the compiled js from this module in a non-Svelte project, then it'd be up to you, the consumable component author, to decide whether you wanted them to have to transpile (or, from the other side, whether you want to force transpiled code even on people who don't need it).

In either case, I don't think transpiling is something that belongs in the official template, but you can of course introduce it in components made from this template.

@thollander
Copy link
Author

Very clear, thanks for the answer @Conduitry !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants