Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paraglide: Fix typing for newLanguage in demo code #337

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

msgeissler
Copy link
Contributor

@msgeissler msgeissler commented Nov 29, 2024

The paraglide demo contains sample code for a language switcher with typing in JSDoc.

Currently the typing is not working, as it is missing curly brackets.

Copy link

changeset-bot bot commented Nov 29, 2024

⚠️ No Changeset found

Latest commit: e855eb3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@manuel3108 manuel3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-cli-337-svelte.vercel.app/

this is an automated message

Copy link

pkg-pr-new bot commented Dec 3, 2024

Open in Stackblitz

npm i https://pkg.pr.new/sveltejs/cli/sv@337
npm i https://pkg.pr.new/sveltejs/cli/svelte-migrate@337

commit: e3257eb

@AdrianGonz97 AdrianGonz97 merged commit 9563557 into sveltejs:main Dec 3, 2024
5 of 8 checks passed
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
@msgeissler msgeissler deleted the patch-1 branch December 3, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants