Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Null Logger Class #88

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Introduce Null Logger Class #88

merged 4 commits into from
Apr 23, 2024

Conversation

connoramoreno
Copy link
Collaborator

@connoramoreno connoramoreno commented Apr 16, 2024 •
edited
Loading

Adds a pseudo logger class, NullLogger, with some of the same class methods as the built-in Python logging class object, but whose methods do nothing when called.

The purpose of NullLogger is to streamline ParaStell code but not enforce logging when using the Python API. A logger does get enforced upon the user when using the command-line interface with YAML input.

Depends on #85.

Closes #46.

@connoramoreno connoramoreno self-assigned this Apr 16, 2024
@connoramoreno connoramoreno requested a review from gonuke April 16, 2024 16:36
@connoramoreno connoramoreno linked an issue Apr 16, 2024 that may be closed by this pull request
Review approach for logger #46
Closed
@gonuke
Copy link
Member

gonuke commented Apr 16, 2024

Let's try to finish #85 first...

@connoramoreno connoramoreno marked this pull request as draft April 16, 2024 19:02
@gonuke
Copy link
Member

gonuke commented Apr 17, 2024

Rebase this on oo_version, please

@connoramoreno connoramoreno marked this pull request as ready for review April 17, 2024 13:38
gonuke
gonuke requested changes Apr 20, 2024
View reviewed changes
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should only use check_init in our class initializers

parastell/invessel_build.py Outdated Show resolved Hide resolved
parastell/magnet_coils.py Outdated Show resolved Hide resolved
parastell/parastell.py Outdated Show resolved Hide resolved
parastell/source_mesh.py Show resolved Hide resolved
gonuke
gonuke approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @connoramoreno

@gonuke gonuke merged commit 054a3f5 into oo_version Apr 23, 2024
@connoramoreno connoramoreno mentioned this pull request Apr 23, 2024
Closed
@connoramoreno connoramoreno deleted the null-logger branch April 26, 2024 20:12
connoramoreno pushed a commit that referenced this pull request Sep 10, 2024
@gonuke
Merge pull request #88 from svalinn/null-logger
30a7477
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonuke gonuke gonuke approved these changes

Assignees

@connoramoreno connoramoreno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review approach for logger
2 participants
@connoramoreno @gonuke