updated cad-to-dagmc API usage for v0.6.2 compatability #77
Conversation
|
ah I just noticed you have a few other active branches. Should I close this and make a new PR against the oo_version branch? |
|
Thanks @shimwell! I can take a closer look at this on Monday. For now, I think getting the fix into |
There was a problem hiding this comment.
Looks good to me @shimwell! I didn't realize it was such a small PR. Have you had the opportunity to test this?
|
Sorry I've not tested this with parastell. Shall we hold off and get some CI on parstell first |
|
I believe we're working on that for the ParaStell upgrade coming in |
There was a problem hiding this comment.
Upon testing, it seems that everything is in working order. Thanks @shimwell!
updated cad-to-dagmc API usage for v0.6.2 compatability
Great to see cad-to-dagmc getting some use. I've been working on that package recently and have made a few releases and improvement
the latest version is 0.6.2 and it moves the material tag to the export call. this was done to allow users to add cad and export to gmsh meshes or unstructured dagmc meshes without needing to give material tags (as they would not be used.
Sorry for the breaking changes.