Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation instructions on main #74

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Conversation

connoramoreno
Copy link
Collaborator

@connoramoreno connoramoreno commented Apr 4, 2024

Updates details about dependencies in the installation instructions on main.

The installation instructions did not accurately reflect ParaStell's Python dependencies. Additional Python dependencies have been added.

Furthermore, this changes installation instructions for PyStell-UW to specify cloning the old branch. There are several issues with the master branch of PyStell-UW that prevent its successful integration with ParaStell.

Copy link
Contributor

@Edgar-21 Edgar-21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me otherwise, have you tested these install instructions? Looks the same as whats in the environment.yml file so I would imagine it works the same

README.md Show resolved Hide resolved
Copy link
Contributor

@Edgar-21 Edgar-21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

@Edgar-21 Edgar-21 merged commit 34f722f into main Apr 4, 2024
@connoramoreno connoramoreno deleted the install_instr_main branch April 26, 2024 20:14
connoramoreno pushed a commit that referenced this pull request Sep 10, 2024
Update installation instructions on `main`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants