Add source mesh modeling #5
Conversation
There was a problem hiding this comment.
Thanks @connoramoreno - hopefully this gets more compact and readable with these changes
There was a problem hiding this comment.
Thanks for exploring the ravel_index version. I can imagine that you find it even less readable :) and I might not disagree. I think we need to talk it over in a s/w meeting. There are some standard patterns for this kind of thing that I think I can share better in person.
| # Initialize vertex index | ||
| i_vert = 0 | ||
| # Compute vertices in Cartesian space | ||
| for i_phi in range(num_phi): |
There was a problem hiding this comment.
Don't the vertices at i_phi = num_phi - 1 overlap with those at i_phi = 0?
I'm not really worried about the memory cost - it's not substantial - but thinking about robustness. The last set of triangles in phi are not connected to the first set. Since we only use this mesh for source sampling, that may not be an issue.
It also may result in complex code to avoid it by reusing the vertices from i_phi = 0
| # Compute closed flux surface index for vertex | ||
| s = i_s * delta_s | ||
|
|
||
| for i_theta in range(num_theta): |
There was a problem hiding this comment.
Don't the vertices at i_theta = num_phi - 1 overlap with those at i_theta = 0?
Add source mesh modeling
Adds ability to model a source mesh based on plasma equilibrium data. The mesh is structured in confinement space and transformed to a tetrahedral mesh in real space.