Create object-oriented version of source mesh generation #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edgar-21
reviewed
Mar 4, 2024
src/sourcemesh.py
Outdated
| create_if_missing = True | ||
| ) | ||
|
|
||
| return |
There was a problem hiding this comment.
I think this return is just hanging out, rest looks good as far as I can tell
Edgar-21
reviewed
Mar 5, 2024
tests/test_sourcemesh.py
Outdated
| num_phi_exp = 4 | ||
| tor_ext = 90.0 | ||
|
|
||
| source_mesh = SourceMesh(vmec, num_s_exp, num_theta_exp, num_phi_exp, |
There was a problem hiding this comment.
should this be something like src.sourcemesh.SourceMesh?
tests/test_sourcemesh.py
Outdated
| num_s_exp = 4 | ||
| num_theta_exp = 8 | ||
| num_phi_exp = 4 | ||
| tor_ext = 90.0 |
There was a problem hiding this comment.
should this be tor_ext_exp?
tests/test_sourcemesh.py
Outdated
|
|
||
| def test_meshbasics(): | ||
|
|
||
| vmec = read_vmec.read_vmec_data(vmec_file) |
| assert source_mesh.num_phi == num_phi_exp | ||
| assert source_mesh.tor_ext == np.deg2rad(tor_ext_exp) | ||
|
|
||
| def test_vertices(): |
There was a problem hiding this comment.
same changes as in test_meshbasics got these tests working for me
There was a problem hiding this comment.
was able to test this in my env, confirmed tests pass with just a couple syntactical changes
This was referenced Mar 7, 2024
Closed
Closed
connoramoreno
pushed a commit
that referenced
this pull request
Sep 10, 2024
Create object-oriented version of source mesh generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #42