Skip imprinting #32
Skip imprinting #32
Conversation
|
I'm happy to approve this, but wonder if someone who can actively test it should be responsible for merging. (@connoramoreno @FusionSandwich ?) |
|
I tested and confirmed that the correct surfaces are being merged. Slick way of doing things @Edgar-21, nicely done. Only thing I'd say before merging has to do with code formatting. Typically, we like to use some kind of standardized style (usually PEP8 in this research group) for things like docstrings, comments, text wrap, line skips, etc. Very minor though, not sure what @gonuke's thoughts are on this topic. |
|
Definitely good to get used to PEP8 formatting ASAP |
|
Made some changes to comments, variable names, line lengths and newlines based on what I read in PEP8, please let me know if I missed anything |
You should look into a PEP8 formatter for your editor that will do this automatically... |
This PR skips the imprint step and instead merges the coincident surfaces using the fact that parastell will import the volumes in inside to outside order. (and some cubit geometry queries)
Likely we will want this to be some sort of setting, right now it just completely replaces the imprint/merge commands, maybe another item in the export dictionary would be the best place to put the option to toggle this, open to suggestions.
For reference imprinting a build with 10 layers took about 50 minutes to imprint for me yesterday, this takes about 5 seconds to merge all coincident surfaces in the example script (7 surfaces to merge)