Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native cubit meshing option #30

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Conversation

Edgar-21
Copy link
Contributor

@Edgar-21 Edgar-21 commented Feb 2, 2024

an additional flag "native_meshing:bool has been added to the the export dict along with the "anisotropic_ratio":Float and the "deviation_angle":Float parameters for the native cubit meshing. Docstrings in parastell and cubit_export have been updated. Default export_def dict has been updated. cubit_export will now check the "native_meshing" flag and either use the new native workflow, or the legacy DAGMC workflow

@Edgar-21 Edgar-21 changed the title Add native cubit meshing option cubit meshing Add native cubit meshing option Feb 2, 2024
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Edgar-21 - just a few high level requests, recommendations

ExampleScript.py Outdated Show resolved Hide resolved
parastell.py Outdated Show resolved Hide resolved
parastell.py Outdated Show resolved Hide resolved
parastell.py Outdated Show resolved Hide resolved
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick question

parastell.py Show resolved Hide resolved
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Edgar-21! This looks good and it will be good to get this out there for others.

@gonuke gonuke merged commit 3aee4b2 into svalinn:main Feb 7, 2024
@Edgar-21 Edgar-21 deleted the add_cubit_meshing branch February 7, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants