-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor filament data use #151
Conversation
7ac3f5c
to
ef58b49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two little code comments....
In a separate issue/PR we should discuss whether you check the extent of the filament data before building the coil?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @connoramoreno
Streamlines and reorganizes use of filament coordinate data as follows:
MagnetCoil
class object as filament coordinate data becomes available in theMagnetSet._instantiate_coils
method (formerly namedMagnetSet._extract_filament_data
), rather than store all filament data separately (and redundantly) in theMagnetSet
class.check_coil_toroidal_extent
method of theMagnetCoil
class, rather than the_filter_coils
method of theMagnetSet
class (formerly namedMagnetSet._filter_filaments
). TheMagnetCoil._check_coil_toroidal_extent
method is called by theMagnetSet._filter_coils
method to subsequently perform the actual filtering.MagnetCoil
class such that all coordinates are stored, and only downsampled during actual CAD solid generation. Note that the downsampled coordinates are not stored as part of any class.Closes #47
Closes #149 (via PR #152)