Adds utility for building the 'magnet surface' and shooting rays at it #142
Conversation
|
I think #139 breaks this - but only a little. Once that gets merged I can update this |
parastell/radial_distance_utils.py
Outdated
| x1 = fil1[index, 0] | ||
| x2 = fil2[index, 0] | ||
| y1 = fil1[index, 1] | ||
| y2 = fil2[index, 1] | ||
| z1 = fil1[index, 2] | ||
| z2 = fil2[index, 2] | ||
| cubit.cmd( | ||
| f"create curve location {x1} {y1} {z1} location {x2} {y2} {z2}" | ||
| ) |
There was a problem hiding this comment.
How about this?
| x1 = fil1[index, 0] | |
| x2 = fil2[index, 0] | |
| y1 = fil1[index, 1] | |
| y2 = fil2[index, 1] | |
| z1 = fil1[index, 2] | |
| z2 = fil2[index, 2] | |
| cubit.cmd( | |
| f"create curve location {x1} {y1} {z1} location {x2} {y2} {z2}" | |
| ) | |
| loc1 = ' '.join(fil1[index,0:2]) | |
| loc2 = ' '.join(fil2[index,0:2]) | |
| cubit.cmd( | |
| f"create curve location {loc1} location {loc2}" | |
| ) |
There was a problem hiding this comment.
need to use list comprehension to make a list of str first but this will work. join() doesn't like to operate on iterables of things that are not str seems like
parastell/radial_distance_utils.py
Outdated
| if point[2] / next_point[2] < 0: | ||
| z_radius = calc_z_radius(point) | ||
| if max_z_radius < z_radius: |
There was a problem hiding this comment.
What if the max z point isn't where the filament crosses the x-y plane?
There was a problem hiding this comment.
Seems like this is a poor variable name. It's called max_z_radius because its should end up being the point where it crosses the x-y plane with the larger distance to the z axis (has the larger radius if the center is the z axis) of the two crossings, not anything to do with the actual z value of the points. The if statement above checks for a sign change in z between the two points, and only checks for what the z radius is if there is a sign change (crosses the xy plane). I'll rename these to something hopefully a bit clearer.
No description provided.