Black autoformatting #135
Merged
Black autoformatting #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonuke
requested changes
Aug 4, 2024
.github/workflows/black.yml
Outdated
| python -m pip install --upgrade pip | ||
| pip install black | ||
|
|
||
| - name: Run Black check |
There was a problem hiding this comment.
Why not use the action provided by black: https://black.readthedocs.io/en/stable/integrations/github_actions.html
There was a problem hiding this comment.
much nicer, thank you
There was a problem hiding this comment.
actually not sure if the change I just made is exactly what you had in mind, this is all relatively mysterious to me still
gonuke
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things.
black --line-length 79 .was run to format all python files with black, and with a line length of 79 characters, per PEP8. Black by default uses 88.black --line-length 79 .does not result in any changes has been added. It runs on pushes, PRs, and manaully.When/if a
pyproject.tomlis authored it should include black args, and the action should be updated to referencepyproject.toml, rather than including the necessary args in the yaml file.