Assume pystell is installed properly in Python environment #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI passing on this one now ✔️ |
|
I didn't realize that pip could be used like that, nice addition. It got me thinking that it should be possible to just include pystell in the |
Add pystell to environment
gonuke
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Thanks @paulromano (& @Edgar-21 ) for making this all cleaner
connoramoreno
pushed a commit
that referenced
this pull request
Sep 10, 2024
Assume pystell is installed properly in Python environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, imports to pystell are of the form
import src.pystell. This appears to be the case because pystell uses asrcdirectory as the root for its Python package. So, if you add the root directory of the pystell git repository to yourPYTHONPATH, the imports work correctly. However, pystell has a pyproject.toml file that should be used rather than manipulating thePYTHONPATHenvironment variable. Specifically, pystell can be installed by simply runningpip install git+https://github.com/aaroncbader/pystell_uw.git.