-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
localize git submodule stuff to only when BUILD_UWUW #968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just thinking about this yesterday! Thanks for this @gonuke!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gonuke! I've tested these changes in Cardinal and can confirm that it solves the CIVET issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me too.
Not sure what to do about the Windows CI failure. Perhaps using the auto-update-conda
to update conda in advance in the miniconda action would help?
https://github.com/conda-incubator/setup-miniconda?tab=readme-ov-file#example-1-basic-usage
I'm working on the Win failures here: #966 |
I rebased this on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Glad the Windows issues were resolved.
We decided to "pause" Windows CI, perhaps with plans to deprecate. It was only ever a priority to support the Cubit plugin, which is no longer a priority. |
Ah, thanks for clarifying! I wasn't following that closely. |
Description
Fixes #967
Changes
Localize the invocation of
git submodules
to occur only whenBUILD_UWUW
is true.