Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hdf5 to v1.14.3 #931

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Update hdf5 to v1.14.3 #931

merged 4 commits into from
Dec 20, 2023

Conversation

ahnaf-tahmid-chowdhury
Copy link
Member

Update Hdf5 to latest

@ahnaf-tahmid-chowdhury ahnaf-tahmid-chowdhury linked an issue Dec 20, 2023 that may be closed by this pull request
@gonuke
Copy link
Member

gonuke commented Dec 20, 2023

To simplify testing, I think we should update linux_build_test.yml in a separate PR once the docker images have been built

@ahnaf-tahmid-chowdhury
Copy link
Member Author

You are saying to update linux_build_test.yml after this PR gets merged?

@gonuke
Copy link
Member

gonuke commented Dec 20, 2023

Relevant tests to build the docker images passed on commit 262678a so I'll consider that sufficient.

@gonuke
Copy link
Member

gonuke commented Dec 20, 2023

Thanks @ahnaf-tahmid-chowdhury

Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this quick update @ahnaf-tahmid-chowdhury . Please submit the linux_build_test.yml update once this merges.

@gonuke gonuke merged commit 3756af6 into develop Dec 20, 2023
10 checks passed
@gonuke
Copy link
Member

gonuke commented Dec 20, 2023

BTW, the update to linux_build_test.yml can come from your fork - it doesn't need to be from a branch in this upstream repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review HDF5 dependencies
2 participants