-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Double Down v1.1.0 Installation in Dockerfile #929
Merged
Changes from 31 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
6166e4f
dd fix
ahnaf-tahmid-chowdhury d057970
fix Geant4_VERSION
ahnaf-tahmid-chowdhury 3cb814f
typo fix
ahnaf-tahmid-chowdhury 0b12126
dd version 1.1.0
ahnaf-tahmid-chowdhury 7d8de72
Double Down v1.1.0 Installation in Dockerfile
ahnaf-tahmid-chowdhury 91245ea
DOUBLE_DOWN_VERSION string fix
ahnaf-tahmid-chowdhury b9c88b6
add space
ahnaf-tahmid-chowdhury 26ad7e3
fix DOUBLE_DOWN_VERSION branch for develop
ahnaf-tahmid-chowdhury 2dfa97b
Update name string
ahnaf-tahmid-chowdhury 2a1133e
Update name string
ahnaf-tahmid-chowdhury fca55ad
allow to chose building geant4 and dd from actions
ahnaf-tahmid-chowdhury 13efae6
double_down default OFF
ahnaf-tahmid-chowdhury ff3ea55
build Geant4 or DD if enabled
ahnaf-tahmid-chowdhury 78c2ac2
fix ${{ env.image_base_tag }}
ahnaf-tahmid-chowdhury 91d51b0
fix syntax error
ahnaf-tahmid-chowdhury 037e6fc
fix syntex
ahnaf-tahmid-chowdhury c3136a9
Merge branch 'develop' into dd-ci-fix
ahnaf-tahmid-chowdhury 42a6ab5
add more conditions to container
ahnaf-tahmid-chowdhury 787403a
DOUBLE_DOWN 1.1.0 REQUIRED
ahnaf-tahmid-chowdhury ef39d66
Update cmake/DAGMC_macros.cmake
ahnaf-tahmid-chowdhury 09dfdb3
update pyne version
gonuke d9adb17
update version strings
gonuke ab2901c
Merge branch 'develop' into dd-ci-fix
ahnaf-tahmid-chowdhury fe7acca
remove extra variables
ahnaf-tahmid-chowdhury d2aaca9
one arg per line
ahnaf-tahmid-chowdhury e62f0ff
OFF -> no
ahnaf-tahmid-chowdhury 27430e7
restore
ahnaf-tahmid-chowdhury 4219b7c
no -> off
ahnaf-tahmid-chowdhury d645877
fix image tag
ahnaf-tahmid-chowdhury b68d9f8
bad substitution fix
ahnaf-tahmid-chowdhury 36adea7
Merge remote-tracking branch 'upstream/develop' into dd-ci-fix
ahnaf-tahmid-chowdhury 5f844bc
move embree to external_deps stage
ahnaf-tahmid-chowdhury 7bd408c
find_package to set min version
ahnaf-tahmid-chowdhury b2609ff
embre 3.6.1
ahnaf-tahmid-chowdhury 61dff56
set min version of DD and Geant4 in legacy way
ahnaf-tahmid-chowdhury abe00a4
if statements in CMake do not require the use of ${} for variable exp…
ahnaf-tahmid-chowdhury 0097561
Merge branch 'develop' into dd-ci-fix
ahnaf-tahmid-chowdhury adcebb2
Merge branch 'develop' into dd-ci-fix
ahnaf-tahmid-chowdhury File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,28 +14,28 @@ jobs: | |
|
||
strategy: | ||
matrix: | ||
ubuntu_versions : [ | ||
ubuntu_version : [ | ||
20.04, | ||
22.04, | ||
] | ||
compiler : [ | ||
gcc, | ||
clang, | ||
] | ||
hdf5_versions : [ | ||
hdf5_version : [ | ||
1.14.3, | ||
] | ||
moab_versions : [ | ||
moab_version : [ | ||
5.4.1, | ||
5.5.1, | ||
] | ||
double_down : [ | ||
OFF, | ||
] | ||
geant_version : [ | ||
geant4_version : [ | ||
10.7.4, | ||
11.1.2 | ||
] | ||
double_down_version : [ | ||
off | ||
] | ||
|
||
name: Installing Dependencies, Building DAGMC and running tests | ||
steps: | ||
|
@@ -58,17 +58,34 @@ jobs: | |
- name: Checkout repository | ||
uses: actions/checkout@v3 | ||
|
||
- name: Configure docker image tag | ||
run: | | ||
image_base_tag=ghcr.io/${{ github.repository_owner }}/ | ||
image_base_tag+=dagmc-ci-ubuntu-${{ matrix.ubuntu_version }} | ||
image_base_tag+=-${{ matrix.compiler}} | ||
image_base_tag+=-hdf5_${{ matrix.hdf5_version}} | ||
image_base_tag+=-moab_${{ matrix.moab_version }} | ||
image_base_tag+=-geant4_${{ matrix.geant4_version }} | ||
image_base_tag+=-double_down_${{ matrix.double_down_version }} | ||
echo "image_base_tag=${image_base_tag}" >> "$GITHUB_ENV" | ||
|
||
- name: Installing Dependencies in Docker image | ||
uses: firehed/multistage-docker-build-action@v1 | ||
with: | ||
repository: ghcr.io/${{ github.repository_owner }}/dagmc-ci-ubuntu-${{ matrix.ubuntu_versions }}-${{ matrix.compiler}}-geant4_${{ matrix.geant_version }}-hdf5_${{ matrix.hdf5_versions}}-moab_${{ matrix.moab_versions }} | ||
repository: ${{ env.image_base_tag }} | ||
stages: base, external_deps, hdf5, moab, dagmc | ||
server-stage: dagmc_test | ||
quiet: false | ||
parallel: true | ||
tag-latest-on-default: ${{ env.tag-latest-on-default }} | ||
dockerfile: CI/Dockerfile | ||
build-args: double_down=${{ matrix.double_down}}, geant4_version=${{ matrix.geant_version }}, COMPILER=${{ matrix.compiler }}, UBUNTU_VERSION=${{ matrix.ubuntu_versions }}, HDF5_VERSION=${{ matrix.hdf5_versions }}, MOAB_BRANCH=${{ matrix.moab_versions }} | ||
build-args: > | ||
UBUNTU_VERSION=${{ matrix.ubuntu_version }}, | ||
COMPILER=${{ matrix.compiler }}, | ||
HDF5_VERSION=${{ matrix.hdf5_version }}, | ||
MOAB_VERSION=${{ matrix.moab_version }}, | ||
GEANT4_VERSION=${{ matrix.geant4_version }}, | ||
DOUBLE_DOWN_VERSION=${{ matrix.double_down_version}} | ||
|
||
|
||
push_stable_ci_img: | ||
|
@@ -77,28 +94,28 @@ jobs: | |
|
||
strategy: | ||
matrix: | ||
ubuntu_versions : [ | ||
ubuntu_version : [ | ||
20.04, | ||
22.04, | ||
] | ||
compiler : [ | ||
gcc, | ||
clang, | ||
] | ||
hdf5_versions : [ | ||
hdf5_version : [ | ||
1.14.3, | ||
] | ||
moab_versions : [ | ||
moab_version : [ | ||
5.4.1, | ||
5.5.1, | ||
] | ||
double_down : [ | ||
OFF, | ||
] | ||
geant_version : [ | ||
geant4_version : [ | ||
10.7.4, | ||
11.1.2 | ||
] | ||
double_down_version : [ | ||
off | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This matrix should probably match the matrix above to make sure all the right images exist. |
||
] | ||
|
||
name: Pushing final images | ||
steps: | ||
|
@@ -110,10 +127,17 @@ jobs: | |
username: ${{ github.repository_owner }} | ||
password: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
- name: Store image name | ||
- name: Configure docker image tag | ||
if: ${{ github.repository_owner == 'svalinn' }} | ||
run: | | ||
echo "image_base_tag=ghcr.io/${{ github.repository_owner }}/dagmc-ci-ubuntu-${{ matrix.ubuntu_versions }}-${{ matrix.compiler }}-geant4_${{ matrix.geant_version }}-hdf5_${{ matrix.hdf5_versions }}-moab_${{ matrix.moab_versions }}" >> "$GITHUB_ENV" | ||
image_base_tag=ghcr.io/${{ github.repository_owner }}/ | ||
image_base_tag+=dagmc-ci-ubuntu-${{ matrix.ubuntu_version }} | ||
image_base_tag+=-${{ matrix.compiler}} | ||
image_base_tag+=-hdf5_${{ matrix.hdf5_version}} | ||
image_base_tag+=-moab_${{ matrix.moab_version }} | ||
image_base_tag+=-geant4_${{ matrix.geant4_version }} | ||
image_base_tag+=-double_down_${{ matrix.double_down_version }} | ||
echo "image_base_tag=${image_base_tag}" >> "$GITHUB_ENV" | ||
|
||
- name: Push Image as latest img | ||
if: ${{ github.repository_owner == 'svalinn' && github.ref == 'refs/heads/develop' }} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,4 +28,3 @@ jobs: | |
with: | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
geant_version: 11.1.2 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahnaf-tahmid-chowdhury : This change introduced a failure - you can’t split this across multiple lines - that we didn’t review carefully enough in the PR. Please submit an update to fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for all the new Docker images to finish building, then we can rerun the Linux tests to see what happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at the failed logs and saw that the failure is because this multi-line container name is resolving with spaces in the name, so it definitely needs to be fixed.