Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 1.11.2 geant4 to routine build testing #927

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

gonuke
Copy link
Member

@gonuke gonuke commented Dec 7, 2023

Add routine testing against Geant4 1.11.2 now that the docker images support it.

I promise this is the last step in getting the Geant4 update done.

@gonuke gonuke changed the title add 11.1.2 geant4 add 1.11.2 geant4 to routine build testing Dec 7, 2023
@gonuke gonuke requested a review from pshriwise December 7, 2023 17:16
@ahnaf-tahmid-chowdhury
Copy link
Member

We are getting DD fail after last merge!

@ahnaf-tahmid-chowdhury
Copy link
Member

Oops! Sorry. DD is failing every time. I may create a PR. It might be due to some configuration error.

@gonuke
Copy link
Member Author

gonuke commented Dec 7, 2023

It's a known issue that DD fails and it fails in an advisory way. @pshriwise is working on a release of DD to fix this

@gonuke gonuke requested a review from shimwell December 8, 2023 22:23
@gonuke
Copy link
Member Author

gonuke commented Dec 8, 2023

Sorry to nag @shimwell or @pshriwise but this really is the end before a release and hopefully more regular releases and conda-forge updates and working towards a pip installable... etc

@shimwell
Copy link
Member

shimwell commented Dec 8, 2023

This looks straightforward to me. Adding another version to the matrix. All the Ci checks passed. Doesn't look like there is much to review here unless I'm missing something

@gonuke
Copy link
Member Author

gonuke commented Dec 11, 2023

You can go ahead and merge @shimwell

@shimwell shimwell merged commit 6b30af4 into svalinn:develop Dec 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants