Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force python3 for the atomicgen.py script as well #792

Merged
merged 3 commits into from
Feb 7, 2022

Conversation

ebknudsen
Copy link
Contributor

Please follow these guidelines when making a Pull Request.
This template was adapted from here and here.

Description

Different conventions for calling python were used in this amalgamation.

Motivation and Context

If e.g. only python3 is installed on a machine the build script will fail.

Changes

Bug fix

Behavior

Current behavior is to call default python then 2 lines later call python3 explicitly. New behavior is to always use python3 explicitly.

@ebknudsen ebknudsen marked this pull request as ready for review February 7, 2022 16:10
@ebknudsen
Copy link
Contributor Author

I believe the changelog is up to date. I simply added this pr number to an existing line (#773, #792)

@gonuke
Copy link
Member

gonuke commented Feb 7, 2022

I believe the changelog is up to date. I simply added this pr number to an existing line (#773, #792)

I agree - I have no idea why it skipped the changelog test 🤷 ?

@gonuke gonuke merged commit dafd3fb into svalinn:develop Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants