Add newer (v2.18) git to CI images #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think these still need to be tested manually, is that right? |
|
These are being tested on my repo... not sure if this is intended, but maybe a good outcome??? |
|
It seems that the test fail on my repo because I don't have push permission to the GHCR (?) |
|
This looks good . I also think that pushing is not working. (we should probably add branch push restriction to avoid random run like this...) I'll issue a PR to have the build run, and maybe tested on PR if that crashes after merge, I'll take full responsibility, and will work on a fix ! Thx @gonuke, Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Install newer git during creation of CI images.
Motivation and Context
Continuous integration relies on having a full peer of the git repo. This was standard during CI on CircleCI, but the Github Action to fetch the repo requires a newer version of git (v2.18+) to accomplish this.
Changes
This changes the packages installed when making the base CI images.