Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compatibility flag required to build PyNE against [email protected]+ #728

Merged
merged 2 commits into from
Feb 25, 2021

Conversation

bam241
Copy link
Member

@bam241 bam241 commented Feb 24, 2021

deprecation in hdf5 1.12 change the interfaces.
this allows to use the old interface with hdf5 1.12+ on which PyNE relies.
see pyne/pyne#1220 for more details

@bam241
Copy link
Member Author

bam241 commented Feb 24, 2021

@gonuke this should fix the [email protected] but again I am unsure this is the right way to do this.

@gonuke
Copy link
Member

gonuke commented Feb 25, 2021

Thanks @bam241 - this does seem like a bandaid, but we'll have to take it for now

@gonuke gonuke merged commit 752f865 into svalinn:develop Feb 25, 2021
@gonuke
Copy link
Member

gonuke commented Feb 25, 2021

@bam241
Copy link
Member Author

bam241 commented Feb 25, 2021

this is very strange, this is one of the 4/5 tests we actually run on PR....

I restarted the one that failed...

@bam241
Copy link
Member Author

bam241 commented Feb 25, 2021

the second run worked.

I don't like that I feel like we are experiencing those more and more...
I am not sure how to debug this, if this is a bug...

@pshriwise
Copy link
Member

It is! I've noticed this too, but haven't had time to look into it. Seeing this thread reminded me to have another look. I'm fairly certain that this has to do with a threadsafe vulnerability in MOAB. I'll make an issue in MOAB's repo and drop the link here for the explanation.

@pshriwise
Copy link
Member

Ok here's the relevant MOAB issue: https://bitbucket.org/fathomteam/moab/issues/135/thread-safety-issue-in-typesequencemanager

I'm not totally sure why we don't see this problem in our MC applications -- we're able to get the same result with 1 as with N threads. My only guess there is that there's enough time between the calls due to other operations. The calls in the overlap_check program are also extremely coherent in terms of the location and ray direction, making it more likely that they'll touch the same data in MOAB and expose these kinds of issues.

@bam241 bam241 deleted the hdf5_12.1 branch November 28, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants