Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding 2022.6 version on build workflow #135

Merged
merged 13 commits into from
Aug 18, 2022
Merged

Conversation

bam241
Copy link
Member

@bam241 bam241 commented Jul 21, 2022

adding 2022.6 in the version stack

@bam241
Copy link
Member Author

bam241 commented Jul 21, 2022

conclusion of the quick test:
Linux build seems to work for all version
MacOS workflow is out-of-date. we need to update it be faire testing anything
Windows seems to have some issue with building MOAB, this might only be related to 2022.6, I'll run more test to figure this out

@bam241
Copy link
Member Author

bam241 commented Jul 21, 2022

Windows seems to have some issue with building MOAB, this might only be related to 2022.6, I'll run more test to figure this out

All windows workflows are broken on MOAB build

adding suggestion from @gonuke

Co-authored-by: Paul Wilson <[email protected]>
@gonuke
Copy link
Member

gonuke commented Jul 21, 2022

Mac is failing because of a deprecated call to finite(). MOAB tries to invoke the correct instance of this function, given that apparently many exist - see MOAB's Util.hpp.

It appears that we may not have access to the MOAB_HAVE_ISFINITE macro, either because we are not accessing the file that sets this (less likely because other things would fail) or that our CMake build of MOAB fails to set this in the config file we do access. This may need MOAB updates.

@bam241
Copy link
Member Author

bam241 commented Jul 22, 2022

I don't believe this is the right diagnostic.
I think you were looking at the build that was cancelled because the build 2021.11 failed:

Run ${system}_build_plugin_pkg 2021.11
[21](https://github.com/svalinn/Cubit-plugin/runs/7456715236?check_suite_focus=true#step:11:22)
+ mac_build_plugin_pkg 2021.11
[22](https://github.com/svalinn/Cubit-plugin/runs/7456715236?check_suite_focus=true#step:11:23)
+ cd /Users/runner/work/Cubit-plugin/Cubit-plugin/..
[23](https://github.com/svalinn/Cubit-plugin/runs/7456715236?check_suite_focus=true#step:11:24)
+ mkdir -p pack/MacOS/plugins/svalinn
[24](https://github.com/svalinn/Cubit-plugin/runs/7456715236?check_suite_focus=true#step:11:25)
+ cd pack/MacOS/plugins/svalinn
[25](https://github.com/svalinn/Cubit-plugin/runs/7456715236?check_suite_focus=true#step:11:26)
+ cp -pPv /Users/runner/work/Cubit-plugin/Cubit-plugin/../lib/libiGeom.dylib /Users/runner/work/Cubit-plugin/Cubit-plugin/../lib/libmcnp2cad.dylib /Users/runner/work/Cubit-plugin/Cubit-plugin/../lib/libsvalinn_plugin.so .
[26](https://github.com/svalinn/Cubit-plugin/runs/7456715236?check_suite_focus=true#step:11:27)
/Users/runner/work/Cubit-plugin/Cubit-plugin/../lib/libiGeom.dylib -> ./libiGeom.dylib
[27](https://github.com/svalinn/Cubit-plugin/runs/7456715236?check_suite_focus=true#step:11:28)
+ cp /usr/local/opt/szip/lib/libsz.2.dylib .
[28](https://github.com/svalinn/Cubit-plugin/runs/7456715236?check_suite_focus=true#step:11:29)
/Users/runner/work/Cubit-plugin/Cubit-plugin/../lib/libmcnp2cad.dylib -> ./libmcnp2cad.dylib
[29](https://github.com/svalinn/Cubit-plugin/runs/7456715236?check_suite_focus=true#step:11:30)
/Users/runner/work/Cubit-plugin/Cubit-plugin/../lib/libsvalinn_plugin.so -> ./libsvalinn_plugin.so
[30](https://github.com/svalinn/Cubit-plugin/runs/7456715236?check_suite_focus=true#step:11:31)
cp: /usr/local/opt/szip/lib/libsz.2.dylib: No such file or directory
[31](https://github.com/svalinn/Cubit-plugin/runs/7456715236?check_suite_focus=true#step:11:32)
Error: Process completed with exit code 1.

the other ones stopped with :
Error: The operation was canceled.

@bam241
Copy link
Member Author

bam241 commented Jul 22, 2022

I think one needs to investigate this:
cp: /usr/local/opt/szip/lib/libsz.2.dylib: No such file or directory

@bam241
Copy link
Member Author

bam241 commented Jul 23, 2022

Mac build works, one need to test it.
Linux build is failing, because of some connection issue, I don't think that comes from us.

Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bam241! One small change that I think makes thinks more robust, and then we can prob merge this.

scripts/unix_share_build.sh Outdated Show resolved Hide resolved
@bam241
Copy link
Member Author

bam241 commented Jul 26, 2022

@gonuke what do we want to do with the Windows build ?

it seems that HDF5 is not playing nicely with MOAB any more....
It would probably be a quick/easy fix, but I don't have the hardware to test it anymore....

@bam241
Copy link
Member Author

bam241 commented Aug 6, 2022

@gonuke what is the plan there ?

Do we want to include the windows fix in there as well ?

@gonuke
Copy link
Member

gonuke commented Aug 6, 2022

I think we can go ahead without the windows fix since we don't have a good place to develop that at the moment

@gonuke
Copy link
Member

gonuke commented Aug 18, 2022

Since I just merged @shimwell 's PR with the Readme table, can you rebase and update that, please?

@gonuke
Copy link
Member

gonuke commented Aug 18, 2022

Actually, maybe this doesn't need a rebase

@gonuke
Copy link
Member

gonuke commented Aug 18, 2022

Merging this now - the updated table in the Readme should come with a release.

@gonuke gonuke merged commit 70dfbef into svalinn:develop Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants