Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dicomio.Reader interface in favor of dicomio.Reader direct struct #319

Closed
suyashkumar opened this issue Jun 1, 2024 · 0 comments · Fixed by #324
Closed

Remove dicomio.Reader interface in favor of dicomio.Reader direct struct #319

suyashkumar opened this issue Jun 1, 2024 · 0 comments · Fixed by #324

Comments

@suyashkumar
Copy link
Owner

No description provided.

@suyashkumar suyashkumar mentioned this issue Jun 1, 2024
Merged
suyashkumar added a commit that referenced this issue Jun 1, 2024
@suyashkumar
Remove Reader interface in favor of using the struct directly, use wr…
65259e5 
…iter struct pointer for consistency (#324)

Making this refactor, along with other API-breaking changes being made in the next release. If users need an interface, they can create one client-side as needed for their use cases! This also matches the Writer to use a pointer struct for consistency.

This closes #319.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@suyashkumar