Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]: base image elfutils version issue #1859

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

SamYuan1990
Copy link
Collaborator

ref https://github.com/sustainable-computing-io/kepler/actions/runs/11814219047/job/32912842046
it seems with elfutils version upgrade, our base image code need to be update accordingly.

Copy link
Contributor

github-actions bot commented Nov 22, 2024

🤖 SeineSailor

Here is a concise summary of the pull request changes:

Summary: This pull request updates the base image's elfutils version from 0.190-2.el9 to 0.191-4.el9 and libbpf version from 1.3.0 to 1.4.0 in the Dockerfile.builder. The changes involve downloading and installing new source RPMs, extracting source tarballs, and configuring, making, and installing the updated libraries.

Key Modifications:

  • Elfutils version update to 0.191-4.el9
  • Libbpf version update to 1.4.0
  • Updated installation and configuration of elfutils and libbpf

Impact: These changes maintain compatibility with the updated base image, ensuring the codebase remains compatible with the latest dependencies. However, they do not affect the external interface or behavior of the code.

Observations/Suggestions:

  • It's essential to keep dependencies up-to-date to avoid potential security vulnerabilities and ensure compatibility with the base image.
  • Consider adding a changelog or release notes to document these changes and their impact on the codebase.
  • Verify that the updated dependencies do not introduce any breaking changes or affect the functionality of the code.

@SamYuan1990
Copy link
Collaborator Author

it seems build success and fail at image sign process without secret available as PR from fork.

@SamYuan1990
Copy link
Collaborator Author

but should we consider to bump up base image tag to libbpf 1.4?

@rootfs rootfs merged commit 16fdd9f into sustainable-computing-io:main Nov 22, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants