Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nit]: update ginkgo version in CI process keep same with go mod #1855

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

SamYuan1990
Copy link
Collaborator

@SamYuan1990 SamYuan1990 commented Nov 21, 2024

@SamYuan1990 SamYuan1990 marked this pull request as draft November 21, 2024 05:56
Copy link
Contributor

github-actions bot commented Nov 21, 2024

🤖 SeineSailor

Here is a concise summary of the pull request changes:

This pull request updates the Ginkgo version in the CI process to v2.20.1, resolving a warning and a nil pointer issue in the test code. The changes include updating the ginkgo-set target in the Makefile and introducing a BeforeEach function call in the vm_stats_test.go file to ensure proper configuration initialization and prevent nil pointer errors. Overall, these changes improve the reliability and stability of the test suite.

@SamYuan1990 SamYuan1990 merged commit dda4de8 into sustainable-computing-io:main Nov 21, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants