feat(dashboard): add detailed node power information #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a detailed node power information table to the overview dashboard. It also works around the OpenShift dashboard UI bug when rendering tables. The bug is that the first column must have unique values. This caused only a single CPU information to be rendered as `kepler_node_info` had components_power_source to be the first item in the list which had `estimator` as the only value. A similar workaround is applied for "Detailed Node Information" table to have `instance` as the first field in the prometheus query result. Signed-off-by: Sunil Thaha <[email protected]>
vprashar2929
merged commit d23df59
into
sustainable-computing-io:v1alpha1
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a detailed node power information table to the overview dashboard. It also works around the OpenShift dashboard UI bug when rendering tables. The bug is that the first column must have unique values. This caused only a single CPU information to be rendered as
kepler_node_infohad components_power_source to be the first item in the list which hadestimatoras the only value.A similar workaround is applied for "Detailed Node Information" table to have
instanceas the first field in the prometheus query result.The issue is better explained in https://issues.redhat.com/browse/OU-309