fix(deployment): do not use generic k8s labels #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, deploying operator created deployment that used generic `control-plane: controller-manager` label. This causes external tools (including the must-gather script) to lookup pods that can belong to **any** deployment that has this label. This commit replaces the label with `app.kubernetes.io/instance: controller-manager`. Fixes: https://issues.redhat.com/browse/POWERMON-159 Signed-off-by: Sunil Thaha <[email protected]>
sthaha
force-pushed
the
fix-controller-labels
branch
from
ea847e4 to
9e89874
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, deploying operator created deployment that used generic
control-plane: controller-managerlabel. This causes external tools(including the must-gather script) to lookup pods that can belong to
any deployment that has this label. This commit replaces the label
with
app.kubernetes.io/instance: controller-manager.Fixes: https://issues.redhat.com/browse/POWERMON-159
Signed-off-by: Sunil Thaha [email protected]