feat: mount redfish credentials #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vimal Kumar <[email protected]>
sthaha
reviewed
Aug 31, 2023
| @@ -49,6 +49,8 @@ const ( | |||
| ServiceName = prefix + "svc" | |||
|
|
|||
| StableImage = "quay.io/sustainable_computing_io/kepler:release-0.5.4" | |||
|
|
|||
| RedfishSecretName = "redfish" | |||
There was a problem hiding this comment.
Where are we creating the secret ? 🤔
There was a problem hiding this comment.
If the redfish secret is optional, how about we allow
exporter:
redfish:
secretRef:
Also, why are we using secret instead of say configmap?
sthaha
reviewed
Aug 31, 2023
| @@ -175,6 +178,7 @@ func NewDaemonSet(detail components.Detail, k *v1alpha1.Kepler) *appsv1.DaemonSe | |||
| k8s.VolumeFromHost("proc", "/proc"), | |||
| k8s.VolumeFromHost("kernel-debug", "/sys/kernel/debug"), | |||
| k8s.VolumeFromHost("kernel-src", "/usr/src/kernels"), | |||
| k8s.VolumeFromSecret("redfish-cred", RedfishSecretName), | |||
There was a problem hiding this comment.
On a related note, there is a down side to this that we should solve .. which is that secrets will be deleted when kepler is deleted :( ... Need to find a way to optionally delete ns if user created objects (including grafana exists).
sthaha
requested changes
Aug 31, 2023
|
/hold |
|
closing this since #364 is merged 🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mounts redfish credentials to the kepler exporter pod