Merge pull request #367 from sthaha/fix-recon-condition

fix: report failure during reconciliation correctly
sustainable-computing-io · Mar 6, 2024 · de5e325 · de5e325
2 parents 4d2756f + 03a414c
commit de5e325
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/controllers/kepler.go b/pkg/controllers/kepler.go
@@ -93,7 +93,7 @@ func (r *KeplerReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr
 	logger.V(6).Info("Running sub reconcilers", "kepler", kepler.Spec)
 
 	result, recErr := r.runKeplerReconcilers(ctx, kepler)
-	updateErr := r.updateStatus(ctx, req, err)
+	updateErr := r.updateStatus(ctx, req, recErr)
 
 	if recErr != nil {
 		return result, recErr

diff --git a/pkg/controllers/kepler_internal.go b/pkg/controllers/kepler_internal.go
@@ -112,7 +112,7 @@ func (r *KeplerInternalReconciler) Reconcile(ctx context.Context, req ctrl.Reque
 	logger.V(6).Info("Running sub reconcilers", "kepler-internal", ki.Spec)
 
 	result, recErr := r.runReconcilers(ctx, ki)
-	updateErr := r.updateStatus(ctx, req, err)
+	updateErr := r.updateStatus(ctx, req, recErr)
 
 	if recErr != nil {
 		return result, recErr