Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Label Support, Active Dot Indicator, and Updated Gradle/Dependencies #35

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

UmairOye
Copy link

This pull request introduces several new features and updates to the curved bottom navigation library:

  1. Added Labels: Labels are now available for each navigation item, and users can change the label color via XML.
  2. Customizable Active Dot Indicator: An active dot indicator shows the selected item, with options to adjust the dot's size and color.
  3. Label Customization: Users can now modify label sizes and colors directly through XML attributes, offering greater flexibility in design.
  4. Gradle and SDK Updates: Updated Gradle configuration, target SDK, and compile SDK to version 34. Also updated all dependencies in both the library and the sample project to their latest versions.
  5. README Update: Revised the README to include instructions on how to set labels, customize dot sizes, and modify label colors.

These changes aim to enhance the functionality and customizability of the curved bottom navigation view, providing more options for developers to fit their UI requirements.

@susonthapa
Copy link
Owner

HI @UmairOye, sorry for the late reply. It has been a while since I worked in this library and I have moved to another stack. I can merge this PR and probably release a new version but I don't know if I will be able to provide support if something goes wrong. If you're willing to maintain the library then I will be more than happy to work together.

@UmairOye
Copy link
Author

UmairOye commented Nov 1, 2024

Hi @susonthapa Yes, I’d be happy to help maintain the library. Let me know how we can proceed from here, and I look forward to working together!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants