Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gorm version and fix wildcards on non strings #4

Merged
merged 7 commits into from
Oct 29, 2024

Conversation

bramca
Copy link

@bramca bramca commented Oct 28, 2024

  • Updated the gorm version:
    the way clauses are set changed a lot in the new version, so there were some code changes needed to keep it working like it used to
  • fix wildcards on non strings:
    some DBs only accept LIKE queries on varchars. A cast to varchar was added so this plugin does not break on non string fields e.g. uuids, datetimes...

Copy link
Owner

@survivorbat survivorbat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick comments

query.go Show resolved Hide resolved
query.go Outdated Show resolved Hide resolved
query_test.go Outdated Show resolved Hide resolved
query_test.go Outdated Show resolved Hide resolved
query_test.go Outdated Show resolved Hide resolved
query_test.go Outdated Show resolved Hide resolved
query_test.go Outdated Show resolved Hide resolved
@survivorbat survivorbat merged commit e755bd2 into survivorbat:master Oct 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants