Accessibility: change page navigation buttons from div to button element #6152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the pipeline ran for longer than 60 minutes. Is there a way to retry? |
koenvangeert
force-pushed
the
koenvg/page-navigation-accessibility
branch
2 times, most recently
from
83dfa2d to
0b01558
Compare
|
@koenvangeert Right now we're preparing to V2 release and actively re-working some of our components. That's why you can have conflists with our changes. As for proposed changes:
Probably desired behavior can be achieved via the ARIA attributes. What do you think about it? |
koenvangeert
force-pushed
the
koenvg/page-navigation-accessibility
branch
from
0b01558 to
9e4b3d8
Compare
koenvangeert
force-pushed
the
koenvg/page-navigation-accessibility
branch
from
9e4b3d8 to
0b5d842
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The page navigation buttons were implemented as
<div>elements, which are not accessible. This PR updates them to use<button>elements, improving accessibility and alignment with semantic HTML best practices.